Skip to content

Integrate Native Block Inserter #24708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 7, 2025
Merged

Integrate Native Block Inserter #24708

merged 4 commits into from
Nov 7, 2025
+228 −12

Conversation

@kean
Copy link
Contributor

@kean kean commented Aug 4, 2025 •
edited
Loading

Integrates new native inserter for Gutenberg.

Testing Instructions

Important: enable "Native Inserter" FF.

  • Verify that the new inserter is shown and smoke test it
  • Verify that for Dotcom sites, "Site Media", "Free Photos", and "Free GIFs" options are available as "secondary" media picker options.
  • Verify that for self-hosted sites, only "Site Media" is an available option.

Known Issues

The routine that handles the selection needs to updated to support using site media without uploading it.

Screenshots

Screenshot 2025-11-06 at 5 07 05 PM

@kean kean added this to the 26.2 milestone Aug 4, 2025
@kean kean added the Gutenberg Editing and display of Gutenberg blocks. label Aug 4, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 4, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@kean kean mentioned this pull request Aug 4, 2025
Closed
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Aug 4, 2025 •
edited
Loading

App Icon📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack
ConfigurationRelease-Alpha
Build Number29693
VersionPR #24708
Bundle IDcom.jetpack.alpha
Commitab0d51f
Installation URL3qnehuk8nle40
 Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Aug 4, 2025 •
edited
Loading

App Icon📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress
ConfigurationRelease-Alpha
Build Number29693
VersionPR #24708
Bundle IDorg.wordpress.alpha
Commitab0d51f
Installation URL16g4do00ur3d8
 Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@kean kean modified the milestones: 26.2, Someday Aug 28, 2025
@kean kean modified the milestones: Someday, 26.5 Oct 28, 2025
@kean kean force-pushed the task/native-block-inserter branch from d55130a to b435245 Compare October 28, 2025 15:58
@kean kean force-pushed the task/native-block-inserter branch from b435245 to 449e825 Compare November 6, 2025 21:39
@dangermattic
Copy link
Collaborator

dangermattic commented Nov 6, 2025

1 Warning
⚠️ This PR is assigned to the milestone 26.5. This milestone is due in less than 4 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@kean kean force-pushed the task/native-block-inserter branch 6 times, most recently from 055080b to c078eca Compare November 6, 2025 22:08
@kean kean requested a review from dcalhoun November 6, 2025 22:09
@kean kean mentioned this pull request Nov 7, 2025
Merged
@dcalhoun dcalhoun mentioned this pull request Nov 7, 2025
Merged
@dcalhoun dcalhoun mentioned this pull request Nov 7, 2025
Merged
@dcalhoun dcalhoun force-pushed the task/native-block-inserter branch from c078eca to cdd2ba7 Compare November 7, 2025 19:09
dcalhoun
dcalhoun reviewed Nov 7, 2025
View reviewed changes
WordPress/Classes/ViewRelated/Media/MediaPicker/Helpers/MediaPickerController.swift
case .playground: menu.makeImagePlaygroundAction(delegate: controller)
case .siteMedia: menu.makeSiteMediaAction(blog: blog, delegate: controller)
case .photos: menu.makePhotosAction(delegate: controller)
case .freePhotos: menu.makeStockPhotos(blog: blog, delegate: controller)
Copy link
Member

@dcalhoun dcalhoun Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the media providers succeeded in my testing accept for this "Free photos" provider. When selecting an image, the request always resulted in a 500 response.

I copied each request as a curl command from Proxyman. When comparing the commands, I noted that the GIF provider included the .gif file ending; contrastingly, the "Free photos" provider lacked a file ending. When I manually added a .jpg file ending, the request succeeded.

Do you experience this? What might causing these 500 responses?

@dcalhoun
Copy link
Member

dcalhoun commented Nov 7, 2025

I encountered a crash with Patterns on WPCOM Simple sites. I fixed this in wordpress-mobile/GutenbergKit#223. Waiting for approval of that before we move forward merging this PR.

dcalhoun
dcalhoun approved these changes Nov 7, 2025
View reviewed changes
Copy link
Member

@dcalhoun dcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. We need to address the 500 responses when using the Free photos media provider, but the native block inserter is behind a feature flag anyways.

@dcalhoun dcalhoun enabled auto-merge November 7, 2025 20:35
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 7, 2025

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@dcalhoun dcalhoun added this pull request to the merge queue Nov 7, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 7, 2025
@dcalhoun dcalhoun added this pull request to the merge queue Nov 7, 2025
Merged via the queue into trunk with commit b378b0b Nov 7, 2025
30 of 32 checks passed
@dcalhoun dcalhoun deleted the task/native-block-inserter branch November 7, 2025 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dcalhoun dcalhoun dcalhoun approved these changes

Assignees

No one assigned

Labels

Gutenberg Editing and display of Gutenberg blocks.

Projects

None yet

Milestone

26.5

Development

Successfully merging this pull request may close these issues.

5 participants

@kean @wpmobilebot @dangermattic @dcalhoun